Skip to content

chore: add unit tests on ci for Windows #7539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 13, 2025
Merged

chore: add unit tests on ci for Windows #7539

merged 2 commits into from
Aug 13, 2025

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Apr 25, 2025

No description provided.

@Varixo Varixo self-assigned this Apr 25, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 25, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: a3ddb70

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Varixo Varixo marked this pull request as ready for review April 25, 2025 08:35
@Varixo Varixo requested a review from a team as a code owner April 25, 2025 08:35
wmertens
wmertens previously approved these changes Apr 25, 2025
View reviewed changes
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gioboa
gioboa previously approved these changes Apr 25, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 25, 2025 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview b6ee935

@Varixo Varixo dismissed stale reviews from gioboa and wmertens via 942bdc5 April 25, 2025 08:51
@Varixo Varixo force-pushed the add-unit-tests-on-ci-for-windows branch from 353df24 to 942bdc5 Compare April 25, 2025 08:51
gioboa
gioboa previously approved these changes Apr 25, 2025
View reviewed changes
@Varixo Varixo force-pushed the add-unit-tests-on-ci-for-windows branch from 942bdc5 to 8f4449f Compare June 28, 2025 20:20
@Varixo Varixo requested review from a team as code owners June 28, 2025 20:20
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 28, 2025
View reviewed changes
.github/workflows/cancel.yml Outdated
Comment on lines 10 to 15
runs-on: ubuntu-latest
steps:
- uses: styfle/[email protected]
if: github.event_name == 'pull_request'
with:
workflow_id: ${{ github.event.workflow.id }}

Check warning

Code scanning / CodeQL

Workflow does not contain permissions

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {{}}

Copilot Autofix

AI about 2 months ago

To fix the issue, we need to add a permissions block to the workflow. This block should specify the least privileges required for the workflow to function correctly. Based on the workflow's purpose (canceling workflow runs), it likely only needs read access to repository contents and workflows. We will add the permissions block at the root level of the workflow to apply it to all jobs.

Suggested changeset 1
.github/workflows/cancel.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/cancel.yml b/.github/workflows/cancel.yml
--- a/.github/workflows/cancel.yml
+++ b/.github/workflows/cancel.yml
@@ -2,2 +2,5 @@
 name: Cancel
+permissions:
+  contents: read
+  workflows: read
 on:
EOF
@@ -2,2 +2,5 @@
name: Cancel
permissions:
contents: read
workflows: read
on:
Copilot is powered by AI and may make mistakes. Always verify output.
@Varixo Varixo changed the base branch from main to build/v2 June 28, 2025 20:20
@Varixo Varixo force-pushed the add-unit-tests-on-ci-for-windows branch 2 times, most recently from 93e732f to a3ddb70 Compare August 13, 2025 20:06
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 13, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7539

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7539

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7539

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7539

commit: b6ee935

Varixo added 2 commits August 13, 2025 22:24
@Varixo
fix: unit tests on Windows
5ce40c1 
# Conflicts:
#	packages/qwik/src/optimizer/src/plugins/rollup.ts
@Varixo
chore: add Windows to the unit tests CI
b6ee935 
# Conflicts:
#	packages/insights/package.json
#	pnpm-lock.yaml
@Varixo Varixo force-pushed the add-unit-tests-on-ci-for-windows branch from a3ddb70 to b6ee935 Compare August 13, 2025 20:26
@Varixo Varixo moved this from Backlog to Waiting For Review in Qwik Development Aug 13, 2025
wmertens
wmertens approved these changes Aug 13, 2025
View reviewed changes
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit 6e90cda into build/v2 Aug 13, 2025
20 checks passed
@wmertens wmertens deleted the add-unit-tests-on-ci-for-windows branch August 13, 2025 20:44
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmertens wmertens wmertens approved these changes

@gioboa gioboa gioboa left review comments

Assignees

@Varixo Varixo

Labels
None yet
Projects
Qwik Development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Varixo @wmertens @gioboa